在Java应用程序中使用JAXBContext解决内存泄漏问题

问题描述 投票:0回答:1

我正在尝试用JAXBContext诊断并解决我认为严重的内存泄漏。然而,尽管有许多尝试这样做,但我没有成功。

简而言之,我的应用程序在执行的前50分钟内使用了少量且一致的内存量。大约50分钟后,类/内存的数量从少于4,000(类)增加到大约8,000(内存类似的增加)。它一直保持这种方式,直到大约1小时16分钟,当在下一个15-20分钟的执行期间,类别数量(在YourKit中观察到)增长到大约246,000。

几乎同一时间内存/类使用增加我的程序开始使用EBay的Java SDK [com.ebay.sdk.pictureservice.eps]将图像上传到eBay服务器。

我分析了Object Allocation Call Tree中的YourKit,似乎我的程序调用了以下方法:

public int uploadPictures(PhotoDisplayCodeType arg0, PictureInfo[] arg1) {
    int arg2 = 0;

    for (int arg3 = 0; arg3 < arg1.length; ++arg3) {
            if (this.uploadPicture(arg0, arg1[arg3])) {
                ++arg2;
        }
    }

 return arg2;
}


public boolean uploadPicture(PhotoDisplayCodeType arg0, PictureInfo arg1) {
    UploadSiteHostedPicturesRequestType arg2 = new UploadSiteHostedPicturesRequestType();
    if (arg0.equals(PhotoDisplayCodeType.SUPER_SIZE) || arg0.equals(PhotoDisplayCodeType.PICTURE_PACK)) {
                arg2.setPictureSet(PictureSetCodeType.SUPERSIZE);
   }

    return this.UpLoadSiteHostedPicture(arg1, arg2);
}


public boolean UpLoadSiteHostedPicture(PictureInfo arg0, UploadSiteHostedPicturesRequestType arg1) {
        ApiLogging arg2 = this.apiContext.getApiLogging();

        System.out.println("Starting picture upload..");

        try {
            Document arg3 = this.marshal(arg1);
            this.addAuthToken(arg3);
            String arg4;
            if (arg2 != null && arg2.isLogSOAPMessages()) {
                arg4 = XmlUtil.getXmlStringFromDom(arg3);
                this.logMessage("UploadSiteHostedPicturesRequest", arg4);
            }


            arg4 = this.xmlToString(arg3);
            String arg5 = this.sendFile(arg0.getPictureFilePath(), arg4);
            if (arg2 != null && arg2.isLogSOAPMessages()) {
                Document arg6 = XmlUtil.createDom(arg5);
                String arg7 = XmlUtil.getXmlStringFromDom(arg6);
                this.logMessage("UploadSiteHostedPicturesResponse", arg7);
            }

            UploadSiteHostedPicturesResponseType arg9 = this.unmarshal(arg5);
            arg0.setReponse(arg9);
            if (arg9.getErrors() != null && arg9.getErrors().length != 0) {
                if (arg9.getErrors().length > 0 && arg9.getAck() == AckCodeType.WARNING) {
                    arg0.setURL(arg9.getSiteHostedPictureDetails().getFullURL());
                    arg0.setErrorType("PICTURE SERVICE RESPONSE WARNING");
                    arg0.setErrorMessage(arg9.getErrors()[0].getShortMessage());
                    if (arg2 != null && arg2.isLogExceptions()) {
                        log.warn("PICTURE SERVICE RESPONSE WARNING");
                        log.warn(arg9.getErrors()[0].getShortMessage());
                    }

                    return true;
                } else {
                    arg0.setErrorType("PICTURE SERVICE RESPONSE ERROR");
                    arg0.setErrorMessage(arg9.getErrors()[0].getShortMessage());
                    if (arg2 != null && arg2.isLogExceptions()) {
                        log.error("PICTURE SERVICE RESPONSE ERROR");
                        log.error(arg9.getErrors()[0].getShortMessage());
                    }

                    return false;
                }
            } else {
                arg0.setURL(arg9.getSiteHostedPictureDetails().getFullURL());
                return true;
            }
        } catch (Exception arg8) {
            arg0.setErrorType("PICTURE SERVICE UPLOAD ERROR");
            arg0.setErrorMessage(arg8.getMessage());
            if (arg2 != null && arg2.isLogExceptions()) {
                log.error("fail to upload picture to eBay picture server!");
                log.error(arg8.getMessage());
            }

            return false;
        }
}



private Document marshal(UploadSiteHostedPicturesRequestType arg0)
            throws JAXBException, ParserConfigurationException {

        **// Is this line causing memory leak?**
        JAXBContext arg1 = JAXBContext.newInstance(new Class[] { UploadSiteHostedPicturesRequestType.class }); 
        Marshaller arg2 = arg1.createMarshaller();
        if (arg0 == null) {
            arg0 = new UploadSiteHostedPicturesRequestType();
        }

        JAXBElement arg3 = (new ObjectFactory()).createUploadSiteHostedPicturesRequest(arg0);
        DocumentBuilderFactory arg4 = DocumentBuilderFactory.newInstance();
        arg4.setNamespaceAware(true);
        DocumentBuilder arg5 = arg4.newDocumentBuilder();
        Document arg6 = arg5.newDocument();
        arg2.marshal(arg3, arg6);
        return arg6;
    }

我的程序连续几次调用uploadPictures()。在我看来,在程序调用此函数时,内存开始急剧增加。

我的诊断是否正确?我该如何解决?

更新:

我找到了这个related thread on SO。如果我的诊断是正确的,它似乎是JAXBContext使用的EBay SDK版本的错误。

更新:

我尝试通过将JAXBContext类更改为单例来解决此问题,但不幸的是它没有解决问题:

public class JAXBContextFactory {
    private static JAXBContextFactory instance = new JAXBContextFactory();

    private static final Map< String, JAXBContext > INSTANCES = new ConcurrentHashMap<String, JAXBContext>();



    private JAXBContextFactory() {
    }

    /**
     * Returns an existing JAXBContext if one for the particular namespace exists, 
     * else it creates an instance adds it to a internal map.
     * @param contextPath the context path
     * @throws JAXBException exception in creating context
     * @return a created JAXBContext
     */
    public JAXBContext getJaxBContext(final String contextPath) throws JAXBException {


     JAXBContext context = INSTANCES.get(contextPath);
        if (context == null) {
            context = JAXBContext.newInstance(contextPath);
            INSTANCES.put(contextPath, context);
        }
        return context;
    }


    /**
     * Returns an existing JAXBContext if one for the particular namespace exists,
     * else it creates an instance adds it to a internal map.
     * @param contextPath the context path
     * @throws JAXBException exception in creating context
     * @return a created JAXBContext
     */
    public JAXBContext getJaxBContext(final Class contextPath) throws JAXBException {
        JAXBContext context = INSTANCES.get(contextPath.getName());
        if (context == null) {
            context = JAXBContext.newInstance(contextPath);
            INSTANCES.put(contextPath.getName(), context);
        }
        return context;
    }

    /**
     * Get instance.
     * @return Instance of this factory
     */
    public static JAXBContextFactory getInstance() {
        return instance;
    }
}

当我在Inspections下看YourKit"Other memory oddities"时,我发现的唯一问题是243,959 "Classes with same name"。当我检查课程时,我看到他们都包含了'JAXB'这个词。基于这些观察,我有几个问题:

1)为什么不是Singleton模式解决创建许多JAXBContext的问题?

2)即使没有Singleton,为什么在我的应用程序明确完成使用/上传图像后,并非所有相关类都被垃圾收集?上传完成后我没有引用JAXBContext类。

谢谢!

java memory-management memory-leaks jaxb yourkit
1个回答
1
投票

在你的marshal(UploadSiteHostedPicturesRequestType arg0)方法中你有这条线

// Is this line causing memory leak?
JAXBContext arg1 = JAXBContext.newInstance(new Class[] { UploadSiteHostedPicturesRequestType.class });

虽然这行不是严格意义上的内存泄漏,但它占用了大量内存,并占用了大量CPU时间,因为它每次都会创建一个新的重JAXBContext对象。从此方法返回后,局部变量JAXBContext arg1不再被引用,但它将保留在内存中,直到它被垃圾收集(这可能不会发生很长时间)。

您应该替换此行

JAXBContext arg1 = JAXBContextFactory.getInstance().getJaxBContext(UploadSiteHostedPicturesRequestType.class);

这应该可以大大改善内存使用和CPU时间。

© www.soinside.com 2019 - 2024. All rights reserved.