这里我将可变的livedata对象作为侦听器传递。可行,但这是正确的实现吗?此实现有任何隐藏的问题,还是有更好的解决方案?
abstract class BaseCallback<T> constructor(private val listener: MutableLiveData<*>) : Callback<T> {
override fun onResponse(call: Call<T>, response: Response<T>) {
when {
response.code() == 401 -> {
}
response.isSuccessful -> {
onSuccess(response.body())
}
else -> {
val apiError = ErrorUtils.parseError(response)
listener.value = ApiResult.Error(exception = apiError!!)
}
}
}
override fun onFailure(call: Call<T>, t: Throwable) {
listener.value = ApiResult.Error(
ApiError(message = t.message ?: "Oops Something Went Wrong!")
)
}
abstract fun onSuccess(response: T?)
}
private val _deviceListResponse = MutableLiveData<ApiResult<List<Device>>>()
val deviceListResponse: LiveData<ApiResult<List<Device>>> = _deviceListResponse
deviceRepo.getDevices().enqueue(object : BaseCallback<List<Device>>(_deviceListResponse) {
override fun onSuccess(response: List<Device>?) {
val devices = response ?: ArrayList()
_deviceListResponse.value = ApiResult.Success(devices)
}
})
不,您不应该将LiveData传递给Callback,BaseCallback应该是独立的,这是一个简单的示例:
fun <T> baseCallBack(onSuccess: (response: T?) -> Unit, onFailure: (apiResult: ApiResult) -> Unit): Callback<T> {
return object : Callback<T> {
override fun onFailure(call: Call<T>, t: Throwable) {
}
override fun onResponse(call: Call<T>, response: Response<T>) {
if (response.isSuccessful) {
onSuccess(response.body())
} else {
onFailure(ApiResult.Error {
ApiError(message = t.message ?: "Oops Something Went Wrong!")
})
}
}
}
}