我有以下代码。它完美地工作,并且由于链接,调用者需要return this
的每个部分:
module.exports = function(res){
return {
success: function(content, contentType, resultCode) {
sendResponse(
res,
content,
validateContentType(contentType),
validateResultCode(resultCode||'ok')
)
return this
},
error: function(resultCode, content, contentType){
sendResponse(
res,
content,
validateContentType(contentType),
validateResultCode(resultCode||'bad_request')
)
return this
},
end: function(callback){
res.end()
callback&&callback()
return this
}
}
}
问题是我需要我的代码传递一组ESLint
规则。上面的代码失败,其中第36行是第一行代码:
36:18 warning Unexpected unnamed function func-names
36:26 error Missing space before function parentheses space-before-function-paren
36:31 error Missing space before opening brace space-before-blocks
38:12 warning Unexpected unnamed method 'success' func-names
38:20 error Missing space before function parentheses space-before-function-paren
43:34 error Infix operators must be spaced space-infix-ops
43:41 error Missing trailing comma comma-dangle
44:5 error Missing semicolon semi
45:15 error Missing semicolon semi
47:10 warning Unexpected unnamed method 'error' func-names
47:18 error Missing space before function parentheses space-before-function-paren
47:52 error Missing space before opening brace space-before-blocks
52:34 error Infix operators must be spaced space-infix-ops
52:50 error Missing trailing comma comma-dangle
53:5 error Missing semicolon semi
54:15 error Missing semicolon semi
56:8 warning Unexpected unnamed method 'end' func-names
56:16 error Missing space before function parentheses space-before-function-paren
56:26 error Missing space before opening brace space-before-blocks
57:13 error Missing semicolon semi
58:4 error Expected an assignment or function call and instead saw an expression no-unused-expressions
58:12 error Infix operators must be spaced space-infix-ops
58:24 error Missing semicolon semi
59:15 error Missing semicolon semi
60:4 error Missing trailing comma comma-dangle
61:3 error Missing semicolon semi
62:2 error Missing semicolon semi
以下片段通过规则,但不是return this
,因为这将导致另一个ESLint
错误,因为no-invalid-this
规则和批判性,不再有效,打破链接:
module.exports = res => ({
success: (content, contentType, resultCode) => {
sendResponse(
res,
content,
validateContentType(contentType),
validateResultCode(resultCode || 'ok'),
);
},
error: (resultCode, content, contentType) => {
sendResponse(
res,
content,
validateContentType(contentType),
validateResultCode(resultCode || 'bad_request'),
);
},
end: (callback) => {
res.end();
if (callback) {
callback();
return undefined;
}
return undefined;
},
});
我的问题是我如何调整第二个片段(或者第一个片段)在功能上与第一个片段相同但仍然通过ESLint
规则?如何正确返回以允许与呼叫者链接?
我的.eslintrc.json
:
{
"extends": "airbnb-base",
"rules": {
// use tabs, not spaces, and in switch statements the case statement should indent again (the default is to be level with the switch)
"indent": [ "error", "tab", { "SwitchCase": 1 } ],
// if you want to put a blank line at the beginning or end of a block, knock yourself out
"padded-blocks": [ "off" ],
// i like tabs. besides, we set indent to require them
"no-tabs": [ "off" ],
// seriously, who cares if there's a blank line at the end of the file or not?
"eol-last": [ "off" ],
// sometimes having a long single line makes sense, this also seems buggy and inconsistent, so we ignore it
"max-len": [ "off" ],
// webstorm repeatedly tries to add it for us. it's easier not to fight it, even if it's not required.
"strict": [ "off" ],
// when setting the property of an object, you can specify the name even if it's unnecessary (ie: { foo: foo })
"object-shorthand": [ "off" ],
// unused vars are an error, except for function arguments.
// particularly with callbacks we may not use all the args, but we still like knowing they're available
"no-unused-vars": [ "error", { "vars": "all", "args": "none", "ignoreRestSiblings": true } ],
// you don't have to use operator assignment if you don't want to
"operator-assignment": [ "warn" ],
// we don't want else to be on the same line as the closing } of an if statement
"brace-style": [ "error", "stroustrup" ],
// warn about overly complex code that you may want to refactor
"complexity": [ "warn", 15 ],
// it's possible that implicit coercion is not what you intended. webstorm warns about it, so should we
"no-implicit-coercion": [ "warn" ],
// if you're using 'this' somewhere that isn't a class you're probably doing something wrong
"no-invalid-this": [ "error" ],
// if you're not modifying the variable used in a loop condition, you've probably done something wrong...
"no-unmodified-loop-condition": [ "warn" ],
// don't use .call or .apply when you don't need to
"no-useless-call": [ "warn" ],
// we want to slap you if you don't update your jsdoc, but not necessarily break one of your fingers
"valid-jsdoc": [ "warn" ],
// forgetting to return after calling a callback is an easy mistake to make, so we'll warn you if you are
"callback-return": [ "warn" ]
}
}
作为eslint rules mentions的文档,你需要给你的匿名函数表达式一个名字(所以它们不再是匿名的)。 顺便说一下,这是一个很好的做法,因为你可以更好地调试它,并在需要时将其称为递归函数。
那为什么不给他们起名字呢?
module.exports = function exports(res) {
return {
success: function success(content, contentType, resultCode) {
sendResponse(
res,
content,
validateContentType(contentType),
validateResultCode(resultCode || 'ok'),
);
return this;
},
error: function error(resultCode, content, contentType) {
sendResponse(
res,
content,
validateContentType(contentType),
validateResultCode(resultCode || 'bad_request'),
);
return this;
},
end: function end(callback) {
res.end();
if (callback) {
callback();
return undefined;
}
return this;
},
}
}
我选择了第三个片段,它在功能上与第一个片段相同,没有ESLint错误,只有ESLint警告:
module.exports = function (res) {
return {
success: function (content, contentType, resultCode) {
sendResponse(
res,
content,
validateContentType(contentType),
validateResultCode(resultCode || 'ok'),
);
return this;
},
error: function (resultCode, content, contentType) {
sendResponse(
res,
content,
validateContentType(contentType),
validateResultCode(resultCode || 'bad_request'),
);
return this;
},
end: function (callback) {
res.end();
if (callback) {
callback();
return undefined;
}
return this;
},
};
};
36:18 warning Unexpected unnamed function func-names
38:12 warning Unexpected unnamed method 'success' func-names
47:10 warning Unexpected unnamed method 'error' func-names
56:8 warning Unexpected unnamed method 'end' func-names
但是,如果有人愿意在我的问题中调整片段2来工作,好像它“返回了这个”,传递我的ESLint错误,警告并在功能上等同于片段1或我的答案,那么我会将答案标记为正确!
我猜你应该为你的方法使用方法语法,而不是函数表达式:
module.exports = (res) => ({
success(content, contentType, resultCode) {
sendResponse(
res,
content,
validateContentType(contentType),
validateResultCode(resultCode || 'ok'),
);
return this;
},
error(resultCode, content, contentType) {
sendResponse(
res,
content,
validateContentType(contentType),
validateResultCode(resultCode || 'bad_request'),
);
return this;
},
end(callback) {
res.end();
if (callback) {
callback();
}
return this;
},
});