异步foreach回调问题

Question

我正在为每个人使用异步来实现一些任务，我面临的问题是最终的回调永远不会执行

场景：我有联系人列表，并希望并行向所有联系人发送消息，并且发送消息时希望将响应存储在数组中，而不想在最终回拨时执行某些操作

sms.js

function SmsService() {}

SmsService.prototype.sendSms = function(value, callback) {

       client.messages
            .create({
                body: value.body,
                from: value.from,
                to: value.to
            })
            .then(message => {
                console.log('meesage going', message.sid);

                callback(null,message.sid)
            })
            .catch(e => {

                callback(null,'not send')

            })
   }


module.exports = SmsService;

sender.js

  var SmsService = require(path.resolve(__dirname, './sms'));
     var smsService = new SmsService();
     var data = [{body:'1232324',from:'[phone]',to:'[phone]'},
     {body:'112123234',from:'[phone]',to:'[phone]'}, {body:'12sadasdasd34',from:'[phone]',to:'[phone]'}]

     async.forEachOf(data, function (value, i, cb) {
        console.log('started',i)
            smsService.sendSms(value, function(error, result) {
                console.log('sending',i,value.to)//only get result for first item 
                results.push(result)
                cb()
            })

     }, function (err) {
        if (err) console.error(err.message);
         console.log('all done')//never executes
        console.log(results);//never executes
    });

如果我将异步部分移动到SMS服务它工作正常，但我想保持单独的SMS服务

Answer 1

你可以尝试这样的事情。

sms.js

function SmsService() {}

SmsService.prototype.sendSms = function(value, callback) {

    return new Promise((resolve, reject) => {
        // Do async job
        client.messages
            .create({
                body: value.body,
                from: value.from,
                to: value.to
            })
            .then(message => {
                console.log('meesage going', message.sid);
                resolve(callback(null,message.sid))
            })
            .catch(e => {
                reject(callback(null,'not send'))
            })
    })
}
module.exports = SmsService;

sender.js

var SmsService = require(path.resolve(__dirname, './sms'));
var smsService = new SmsService();
var data = [{body:'1232324',from:'[phone]',to:'[phone]'},
            {body:'112123234',from:'[phone]',to:'[phone]'}, 
            {body:'12sadasdasd34',from:'[phone]',to:'[phone]'}];
var promises = [];
data.forEach(async function (obj, index) {
    console.log('started',index)

    promises.push(await smsService.sendSms(obj, function(error, result) {
        console.log('sending',i,value.to)//only get result for first item 
        results.push(result)
    }));
});

Promise.all(promises).then(function () {
        console.log("Messages sent")
}).catch(function (err) {
        console.log("Messages not sent")
})